Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-83499: Fix closing file descriptors in tempfile #93874

Merged
merged 3 commits into from Jun 26, 2022
Merged

gh-83499: Fix closing file descriptors in tempfile #93874

merged 3 commits into from Jun 26, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 15, 2022 •
edited

Closes #83499.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 17, 2022
Closed
@serhiy-storchaka serhiy-storchaka requested a review from pitrou Jun 17, 2022
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Jun 17, 2022

@pitrou, please take a look at this PR.

@serhiy-storchaka serhiy-storchaka merged commit d4792ce into python:main Jun 26, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 26, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 26, 2022

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d4792ce916b94d090b6c7bce8b0f973e840c9e4e 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2022
@serhiy-storchaka @miss-islington
pythongh-83499: Fix closing file descriptors in tempfile (pythonGH-93874
f4764fd 
)

(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 26, 2022

GH-94287 is a backport of this pull request to the 3.10 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 26, 2022
@serhiy-storchaka
[3.11] pythongh-83499: Fix closing file descriptors in tempfile (pyth…
5490b34 
…onGH-93874)

(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the tempfile-close-fd2 branch Jun 26, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jun 26, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2022
@serhiy-storchaka @miss-islington
pythongh-83499: Fix closing file descriptors in tempfile (pythonGH-93874
396fbfa 
)

(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 26, 2022

GH-94289 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Jun 26, 2022
@miss-islington @serhiy-storchaka
gh-83499: Fix closing file descriptors in tempfile (GH-93874)
82f9041 
(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jun 26, 2022
@miss-islington @serhiy-storchaka
gh-83499: Fix closing file descriptors in tempfile (GH-93874)
68112c3 
(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NamedTemporaryFile could cause double-close on an fd if _TemporaryFileWrapper throws
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot