Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95174: Handle missing waitpid and gethostbyname in WASI (GH-95181) #95181

Merged
merged 1 commit into from Jul 24, 2022
Merged

gh-95174: Handle missing waitpid and gethostbyname in WASI (GH-95181) #95181

merged 1 commit into from Jul 24, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 23, 2022 •
edited by bedevere-bot

WASI has no process or netdb API. The code will fail with AttributeError
when we remove the stubs from WASIX.

@tiran
pythongh-95174: Handle missing waitpid and gethostbyname in WASI
33b4f4f 
WASI has no process or netdb API. The code will fail with AttributeError
when we remove the stubs from WASIX.
@tiran tiran requested a review from gpshead as a code owner Jul 23, 2022
gpshead
gpshead approved these changes Jul 24, 2022
View changes
Copy link
Member

@gpshead gpshead left a comment

ugh, but this does seem to be the simplest way for now.

@tiran tiran changed the title gh-95174: Handle missing waitpid and gethostbyname in WASI gh-95174: Handle missing waitpid and gethostbyname in WASI (GH-95181) Jul 24, 2022
@tiran tiran merged commit 8184f0f into python:main Jul 24, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 24, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-95174-subprocess branch Jul 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 24, 2022
@tiran @miss-islington
pythongh-95174: Handle missing waitpid and gethostbyname in WASI (pyt…
c068aef 
…honGH-95181)

(cherry picked from commit 8184f0f)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Jul 24, 2022

GH-95190 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Jul 24, 2022
@miss-islington @tiran
gh-95174: Handle missing waitpid and gethostbyname in WASI (GH-95181)
00cda6b 
(cherry picked from commit 8184f0f)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiran @miss-islington @bedevere-bot @gpshead