Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upURI Traversing misses uris within functions #59
Closed
Labels
Comments
I'm able to fix this in kotlin with something like: private inner class CompleteCSSVisitorForUrl(visitor: ICSSUrlVisitor) : CSSVisitorForUrl(visitor) {
override fun onDeclaration(decl: CSSDeclaration) {
val expr = decl.expression
onExpression(decl, expr)
}
private fun onExpression(decl: CSSDeclaration, expr: CSSExpression) {
for (member in expr.allMembers) when (member) {
is CSSExpressionMemberTermURI -> {
visitor.onUrlDeclaration(null, decl, member)
}
is CSSExpressionMemberFunction -> {
member.expression?.let { onExpression(decl, it) }
}
}
}
} Obviously this isn't quite correct WRT to the visitor interface, but works for my usecase. |
Thank you for that snippet |
Ah forget half of my previous comment. I just fix the |
This is part of the 6.2.3 release that is building as I type |
Wow thanks for the quick turnaround and release here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example CSS:
I would expect that this example: https://github.com/phax/ph-css/blob/master/ph-css/src/test/java/com/helger/css/supplementary/wiki/WikiVisitDataUrls.java
Would print out urls for this snippet, but it does not.