will always take the exception path because both decomp_data and decomp are lists of ints, so the index call always raises. I think it was copy-pasted from some similar code a few lines up which however is about a lists of strings and a string, so it works there.
I will prepare a PR. The space saving isn't gigantic (about 4.5kib) but as it stands the code is confusing.
The text was updated successfully, but these errors were encountered:
cfbolz commentedAug 16, 2022
I was reading
makeunicodedata.py
and found a small issue that leads to a bit of wasted space in theunicodedata
module. This code:will always take the exception path because both
decomp_data
anddecomp
are lists of ints, so theindex
call always raises. I think it was copy-pasted from some similar code a few lines up which however is about a lists of strings and a string, so it works there.I will prepare a PR. The space saving isn't gigantic (about 4.5kib) but as it stands the code is confusing.
The text was updated successfully, but these errors were encountered: