[Serializer] Try all possible denormalization route with union types when ALLOW_EXTRA_ATTRIBUTES=false #45861
+69
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-bond
force-pushed
the
ticket_45860
branch
2 times, most recently
from
41f9034
to
1d65cef
Compare
|
Hey! I think @Th3Mouk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
NorthBlue333
reviewed
Jun 12, 2022
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
|
Hello there, |
|
This PR is ready for review. |
dunglas
approved these changes
Jun 13, 2022
nicolas-grekas
changed the title
…when ALLOW_EXTRA_ATTRIBUTES=false
nicolas-grekas
approved these changes
Jun 19, 2022
|
Thank you @T-bond. |
nicolas-grekas
added a commit
that referenced
this issue
Jun 26, 2022
…tor (Gwemox) This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Fix denormalization union types with constructor | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46396 | License | MIT Fix bug when deserialize union types with constructor. Before that, `MissingConstructorArgumentsException` was thrown even if another type matched. Is similar to #45861 Commits ------- 33fb153 [Serializer] Fix denormalization union types with constructor
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I found a similar bug, (I think this is a bug, but it is possible, it is an intended behaviour) to my previous report.