Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer] Fix for missing sender name in case with usage of the EnvelopeListener #46368

Merged
merged 1 commit into from Jun 9, 2022
Merged

[Mailer] Fix for missing sender name in case with usage of the EnvelopeListener #46368

merged 1 commit into from Jun 9, 2022

Conversation

bobahvas
Copy link
Contributor

@bobahvas bobahvas commented May 16, 2022

Q A
Branch? 4.4, 5.4 or 6.0
Bug fix? yes
New feature? no
Deprecations? no
License MIT 
$eventDispatcher = new \Symfony\Component\EventDispatcher\EventDispatcher();
$eventDispatcher->addSubscriber(
    new \Symfony\Component\Mailer\EventListener\EnvelopeListener(
        new \Symfony\Component\Mime\Address('noreply@test.com', 'TestName')
    )
);

@carsonbot carsonbot added this to the 4.4 milestone May 16, 2022
@carsonbot
Copy link

@carsonbot carsonbot commented May 16, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 17, 2022

Please add a test case.

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 9, 2022

friendly ping @bobahvas

fabpot
fabpot approved these changes Jun 9, 2022
View changes
@fabpot
Copy link
Member

@fabpot fabpot commented Jun 9, 2022

Thank you @bobahvas.

@fabpot fabpot merged commit e94f1f6 into symfony:4.4 Jun 9, 2022
10 checks passed
@bobahvas
Copy link
Contributor Author

@bobahvas bobahvas commented Jun 9, 2022

@nicolas-grekas @fabpot sorry for the delay, I am super busy. I will add tests a little bit later

@fabpot fabpot mentioned this pull request Jun 26, 2022
Merged
@fabpot fabpot mentioned this pull request Jun 26, 2022
Merged
@fabpot fabpot mentioned this pull request Jun 26, 2022
Merged
@fabpot fabpot mentioned this pull request Jun 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobahvas @carsonbot @nicolas-grekas @fabpot