Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Escape % in command name & description from getDefaultName() #46595

Merged
merged 1 commit into from Jun 7, 2022

Conversation

ogizanagi
Copy link
Member

@ogizanagi ogizanagi commented Jun 6, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46560
License MIT
Doc PR N/A

Backport of #46574 for 4.4

@ogizanagi ogizanagi requested a review from chalasr as a code owner Jun 6, 2022
@carsonbot carsonbot added this to the 4.4 milestone Jun 6, 2022
@ogizanagi ogizanagi changed the title [Console] Escape % in command name & description from getDefault*() [Console] Escape % in command name & description from getDefaultName() Jun 6, 2022
@carsonbot
Copy link

@carsonbot carsonbot commented Jun 7, 2022

Hey!

I think @jschaedl has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

stof
stof approved these changes Jun 7, 2022
@chalasr
Copy link
Member

@chalasr chalasr commented Jun 7, 2022

Thank you @ogizanagi.

@chalasr chalasr merged commit d8212cb into symfony:4.4 Jun 7, 2022
8 of 9 checks passed
@ogizanagi ogizanagi deleted the console-escape-descr-name-params branch Jun 7, 2022
@fabpot fabpot mentioned this pull request Jun 9, 2022
This was referenced Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants