Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] Fix width method in AbstractUnicodeString #47010

Merged
merged 1 commit into from Jul 24, 2022

Conversation

TBoileau
Copy link
Contributor

@TBoileau TBoileau commented Jul 21, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47004
License MIT
Doc PR none - bugfix

This PR ensures that the width method of AbstractUnicodeString returns the width and not the length of the text.

Copy link
Member

@dunglas dunglas left a comment

LGTM

Copy link
Member

@dunglas dunglas left a comment

LGTM

fabpot
fabpot approved these changes Jul 24, 2022
@fabpot
Copy link
Member

@fabpot fabpot commented Jul 24, 2022

Thank you @TBoileau.

@fabpot fabpot merged commit c02b704 into symfony:5.4 Jul 24, 2022
4 of 6 checks passed
This was referenced Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants