[Cache] make Redis*Proxy extend Redis*
#47292
Merged
+4,555
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
cache-proxy
branch
4 times, most recently
from
a6b5aad
to
269791d
Compare
stof
reviewed
Aug 16, 2022
| /** | ||
| * @internal | ||
| */ | ||
| class RedisCluster6Proxy extends \RedisCluster |
There was a problem hiding this comment.
Wouldn't those committed proxies break if Redis has a new method in a minor version ?
There was a problem hiding this comment.
They would. That's why I added a test case to ensure we're in sync.
There was a problem hiding this comment.
but then, this means that all existing releases of Symfony become broken when ext-redis releases a new version, until we release a version with the new methods. I find that quite bad DX for our users.
There was a problem hiding this comment.
They are not really broken until you start using the new methods. I think this is acceptable since ppl using the new methods can wait a new release. The window should be pretty short.
nicolas-grekas
force-pushed
the
cache-proxy
branch
3 times, most recently
from
73b05fe
to
e21267e
Compare
nicolas-grekas
force-pushed
the
cache-proxy
branch
3 times, most recently
from
39fa090
to
b67509c
Compare
nicolas-grekas
force-pushed
the
cache-proxy
branch
2 times, most recently
from
0f57be2
to
df78694
Compare
|
(PR rebased and ready) |
Seb33300
reviewed
Sep 4, 2022
nicolas-grekas
force-pushed
the
cache-proxy
branch
4 times, most recently
from
99c13cc
to
9e703c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Redis*Proxydid not extend native classes because we missed the code infrastructure to generate appropriate proxies.With #47236, we now have it. This PR adds generated proxies to the cache component to keep it lazy-able out of the box.