Skip to content

[Clock] fix transient NativeClock test #47270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 12, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 6.2 milestone Aug 12, 2022
@xabbuh
Copy link
Member Author

xabbuh commented Aug 12, 2022

Status: Needs work

@xabbuh
Copy link
Member Author

xabbuh commented Aug 13, 2022

Status: Needs Review

@fabpot
Copy link
Member

fabpot commented Aug 14, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit fc868f4 into symfony:6.2 Aug 14, 2022
@xabbuh xabbuh deleted the clock-tests branch August 14, 2022 14:26
xabbuh added a commit to xabbuh/symfony that referenced this pull request Aug 18, 2022
…abbuh)"

This reverts commit fc868f4, reversing
changes made to 2e87d30.
xabbuh added a commit that referenced this pull request Aug 18, 2022
…(xabbuh)

This PR was merged into the 6.2 branch.

Discussion
----------

revert #47270 to not use microtime() in the NativeClock

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

21f4055 Revert "minor #47270 [Clock] fix transient NativeClock test (xabbuh)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants