[DoctrineBridge] Make EntityValueResolver::supports() more specific #47339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Aug 19, 2022
jderusse
approved these changes
Aug 20, 2022
|
test case for the new unsupported cases is welcome |
stof
approved these changes
Aug 22, 2022
nicolas-grekas
commented
Aug 22, 2022
| @@ -162,40 +169,55 @@ private function getIdentifier(Request $request, MapEntity $options, string $nam | |||
| } | |||
|
|
|||
| if ($request->attributes->has($name)) { | |||
| return $request->attributes->get($name); | |||
| return $request->attributes->get($name) ?? ($options->stripNull ? false : null); | |||
There was a problem hiding this comment.
works for me (with a test case 😉 )
There was a problem hiding this comment.
test case updated
jderusse
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make
EntityValueResolveras specific as possible so that it resolves only arguments that are actual entities.Would that make sense to you? (before I fix tests)
/cc @jderusse et al.