Skip to content

docs: add Angular Master website to resources list #47129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: add Angular Master website to resources list #47129

wants to merge 1 commit into from

Conversation

kalbarczyk
Copy link
Contributor

@kalbarczyk kalbarczyk commented Aug 11, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mgechev August 11, 2022 15:49
@pkozlowski-opensource pkozlowski-opensource added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 11, 2022
@ngbot ngbot bot modified the milestone: Backlog Aug 11, 2022
kalbarczyk
kalbarczyk commented Aug 12, 2022
View reviewed changes
Copy link
Contributor Author

@kalbarczyk kalbarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The course has the word "master" in its name.

@bob-watson
Copy link
Contributor

It's a little awkward that he's built a brand around a term we're trying to avoid to be inclusive.

@kalbarczyk
Copy link
Contributor Author

It's a little awkward that he's built a brand around a term we're trying to avoid to be inclusive.

I don't quite understand?

We also have 2 podcasts:

Angular Master Podcast and JavaScript Master Podcast.

https://anchor.fm/angular-master
https://anchor.fm/javascript-master

Is there any chance to add them to the site?

@mgechev mgechev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 22, 2022
@alxhub
Copy link
Member

alxhub commented Aug 22, 2022

This PR was merged into the repository by commit b343201.

alxhub pushed a commit that referenced this pull request Aug 22, 2022
@kalbarczyk @alxhub
docs: add Angular Master website to resources list (#47129)
e717980 
PR Close #47129
@alxhub alxhub closed this in b343201 Aug 22, 2022
alxhub pushed a commit that referenced this pull request Aug 22, 2022
@kalbarczyk @alxhub
docs: add Angular Master website to resources list (#47129)
474eec7 
PR Close #47129
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@kalbarczyk @bob-watson @alxhub @mgechev @pkozlowski-opensource