gh-92839: fixed typo in _bisectmodule.c (line 131) #92849
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
Please add the OP's test case. And also a Misc/NEWS entry. |
|
@rhettinger Sure I can do this. I noticed |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
serhiy-storchaka
added
type-bug
|
@rhettinger Are these changes okay? |
|
Thanks @oda-gitso for the PR, and @rhettinger for merging it |
|
Sorry @oda-gitso and @rhettinger, I had trouble checking out the |
) (cherry picked from commit 7fa9b7d) Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
|
GH-93321 is a backport of this pull request to the 3.10 branch. |
|
Thanks @oda-gitso for the PR, and @rhettinger for merging it |
|
GH-93322 is a backport of this pull request to the 3.11 branch. |
) (cherry picked from commit 7fa9b7d) Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
Issue #92839. Line 131 says
if (x == NULL). It appearsif (key_x == NULL)was intended.I am not sure exactly what the procedure is here. The same typo exists in earlier versions of Python as well. Do we need to do anything about that?