report: add queue info for UDP #44345
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
theanarkh
force-pushed
the
add_more_fields_in_report
branch
3 times, most recently
from
e5637f9
to
3d7c1dc
Compare
theanarkh
force-pushed
the
add_more_fields_in_report
branch
from
3d7c1dc
to
3bc2c6f
Compare
|
Done! |
legendecas
reviewed
Aug 23, 2022
We already have a dedicated validator for udp handles in report: https://github.com/nodejs/node/blob/main/test/report/test-report-uv-handles.js#L252. I'd find it would be beneficial to extend this test instead of creating a new one.
|
Oh, thanks, i will update it later. |
theanarkh
force-pushed
the
add_more_fields_in_report
branch
from
3bc2c6f
to
762b311
Compare
richardlau
approved these changes
Aug 23, 2022
legendecas
approved these changes
Aug 23, 2022
github-actions
bot
removed
the
request-ci
theanarkh
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d9b2d2c |
This was referenced Aug 24, 2022
sidwebworks
pushed a commit
to sidwebworks/node
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs#44345 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This was referenced Aug 27, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
PR-URL: #44345 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
PR-URL: nodejs#44345 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 16, 2022
PR-URL: #44345 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
add queue info for UDP.
make -j4 test(UNIX), orvcbuild test(Windows) passes