Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-90473: Skip get_config_h() tests on WASI (GH-93645) #93645

Merged
merged 1 commit into from Jun 9, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 9, 2022

The test cases are incompatible with WASI mapdir and OOT builds.
wasmtime starts the process with / as CWD, but the files are in a
subdirectory.

The test cases are incompatible with WASI mapdir and OOT builds.
wasmtime starts the process with ``/`` as CWD, but the files are in a
subdirectory.
@bedevere-bot bedevere-bot added tests awaiting core review labels Jun 9, 2022
@tiran tiran changed the title gh-90473: Skip get_config_h() tests on WASI gh-90473: Skip get_config_h() tests on WASI (GH-93645) Jun 9, 2022
@tiran tiran merged commit 6099611 into python:main Jun 9, 2022
12 checks passed
@tiran tiran deleted the gh-90473-wasi-pyconfigh branch Jun 9, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 9, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 9, 2022
(cherry picked from commit 6099611)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 9, 2022

GH-93650 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this issue Jun 9, 2022
(cherry picked from commit 6099611)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants