gh-84461: Fix parallel testing on WebAssembly (GH-93768) #93768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emscripten and WASI have stubbed getpid() syscall that always returns the same value. Use time and random value instead of pid to create a unique working directory.
vstinner
reviewed
Jun 13, 2022
vstinner
approved these changes
Jun 13, 2022
LGTM. It's better if test_cwd is unique system-wide, but it's not a strict requirement. Chosen nonce is good for uniqueness ;-)
carlbordum
reviewed
Jun 13, 2022
Lib/test/libregrtest/main.py
Outdated
| @@ -628,7 +628,12 @@ def create_temp_dir(self): | |||
| # Define a writable temp dir that will be used as cwd while running | |||
| # the tests. The name of the dir includes the pid to allow parallel | |||
| # testing (see the -j option). | |||
| pid = os.getpid() | |||
| # Emscripten and WASI have stubbed getpid(), Emscripten has only | |||
| # milisecond clock resolution. Use time_ns() + randint() instead. | |||
There was a problem hiding this comment.
Why use time.time_ns if it has only "milisecond clock resolution"?
tiran
changed the title
|
Thanks @tiran for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jun 13, 2022
(cherry picked from commit c200757) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-93782 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this issue
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Emscripten and WASI have stubbed getpid() syscall that always returns
the same value. Use time and random value instead of pid to create a
unique working directory.