Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93616: Fix env changed issue in test_modulefinder #93617

Merged
merged 1 commit into from Jun 9, 2022
Merged

gh-93616: Fix env changed issue in test_modulefinder #93617

merged 1 commit into from Jun 9, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 8, 2022

No description provided.

@bedevere-bot bedevere-bot added tests awaiting core review labels Jun 8, 2022
@tiran tiran linked an issue Jun 8, 2022 that may be closed by this pull request
test_modulefinder always modifies execution environment #93616
Closed
carlbordum
carlbordum approved these changes Jun 8, 2022
View changes
Copy link
Contributor

@carlbordum carlbordum left a comment

LGTM

@tiran tiran merged commit cffa4f7 into python:main Jun 9, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 9, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-93616-modulefinder branch Jun 9, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 9, 2022

GH-93630 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 9, 2022
@tiran @miss-islington
pythongh-93616: Fix env changed issue in test_modulefinder (pythonGH-…
0d1b687 
…93617)

(cherry picked from commit cffa4f7)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this issue Jun 9, 2022
@miss-islington @tiran
gh-93616: Fix env changed issue in test_modulefinder (GH-93617)
98bbbbe 
(cherry picked from commit cffa4f7)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbordum carlbordum

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_modulefinder always modifies execution environment
4 participants
@tiran @miss-islington @bedevere-bot @carlbordum