Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93660: Change list to view object in SymbolTable docstring #93661

Merged
merged 1 commit into from Jun 11, 2022

Conversation

pamelafox
Copy link
Contributor

@pamelafox pamelafox commented Jun 9, 2022

This PR changes the docstring and RST to accurately describe the return value. I included a link to the dictionary views reference since that's what dict.keys() does. I could not find any other examples of stdlib functions/methods that return dictionary view objects (outside of dict) so I'm not sure if there's a clearer way to describe them.

@cpython-cla-bot
Copy link

@cpython-cla-bot cpython-cla-bot bot commented Jun 9, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 9, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 11, 2022

Thanks for your contribution @pamelafox 🎉

@pablogsal pablogsal merged commit 5d8e7a1 into python:main Jun 11, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 11, 2022

Thanks @pamelafox for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 11, 2022

Thanks @pamelafox for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 11, 2022
(cherry picked from commit 5d8e7a1)

Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 11, 2022

GH-93722 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 11, 2022
(cherry picked from commit 5d8e7a1)

Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 11, 2022

GH-93723 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Jun 11, 2022
(cherry picked from commit 5d8e7a1)

Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
miss-islington added a commit that referenced this issue Jun 11, 2022
(cherry picked from commit 5d8e7a1)

Co-authored-by: Pamela Fox <pamela.fox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants