Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90153: whatsnew: "z" option in format spec #93624

Merged
merged 2 commits into from Jun 11, 2022
Merged

gh-90153: whatsnew: "z" option in format spec #93624

merged 2 commits into from Jun 11, 2022
+3 −0

Conversation

belm0
Copy link
Contributor

@belm0 belm0 commented Jun 8, 2022

No description provided.

@bedevere-bot bedevere-bot added docs awaiting review labels Jun 8, 2022
@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jun 9, 2022

This was a PEP - perhaps it should go after exception groups in the 'PEP sized items' section? (~L70)

A

@belm0
Copy link
Contributor Author

@belm0 belm0 commented Jun 9, 2022

This was a PEP - perhaps it should go after exception groups in the 'PEP sized items' section? (~L70)

I struggled about where to place it. Even though it had a PEP so we could get consensus on touching the format spec at all, this is a relatively minor addition and doesn't seem to warrant being in the highlight section.

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jun 9, 2022

There's no specific editor listed for 3.11's What's New so perhaps @pablogsal could give a quick opinion?

A

@mdickinson
Copy link
Member

@mdickinson mdickinson commented Jun 9, 2022

+1. Agreed that this isn't a PEP-size change (despite having had a PEP), but it definitely deserves a mention in the what's new.

@mdickinson
Copy link
Member

@mdickinson mdickinson commented Jun 11, 2022

@AA-Turner I suggest we merge this as-is. @pablogsal can move it later if he deems it important enough.

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jun 11, 2022

I suggest we merge this as-is

Sounds good!

A

@mdickinson mdickinson merged commit 010284b into python:main Jun 11, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 11, 2022

Thanks @belm0 for the PR, and @mdickinson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 11, 2022
@belm0 @miss-islington
pythongh-90153: whatsnew: "z" option in format spec (pythonGH-93624)
75e5bda 
Add what's new entry for PEP 682 in Python 3.11.
(cherry picked from commit 010284b)

Co-authored-by: John Belmonte <john@neggie.net>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 11, 2022

GH-93717 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this issue Jun 11, 2022
@miss-islington @belm0
gh-90153: whatsnew: "z" option in format spec (GH-93624)
36ece2e 
Add what's new entry for PEP 682 in Python 3.11.
(cherry picked from commit 010284b)

Co-authored-by: John Belmonte <john@neggie.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson

@AA-Turner AA-Turner

Assignees
No one assigned
Labels
docs skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@belm0 @AA-Turner @mdickinson @miss-islington @bedevere-bot