Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history router mode search result fix #1748

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

history router mode search result fix #1748

wants to merge 3 commits into from

Conversation

ayu-666
Copy link

@ayu-666 ayu-666 commented Feb 7, 2022 •
edited by trusktr

Summary

in History mode, search results should not link to hash routes, but to regular routes.

What kind of change does this PR introduce?

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Feb 7, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsifyjs/docsify-preview/PWJQzpZ3mQoB6jc42Qwc1iSw9ziM
✅ Preview: https://docsify-preview-git-fork-ayu-666-patch-1-docsifyjs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 7, 2022 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 90867f9:

Sandbox Source
docsify-template Configuration

@jhildenbiddle
Copy link
Member

jhildenbiddle commented Feb 7, 2022 •
edited

@ayu-666 --

Please provide a more detailed description of the issue being fixed, steps to reproduce, screenshots (if appropriate), etc. Without this kind of more information, PRs can not be tested and approved. Thanks!

@trusktr
Copy link
Member

trusktr commented Feb 9, 2022

Based on the change, this makes search results not use # in front of URLs for search results, because in History mode we do not want to navigate to hashes.

@ayu-666 can you please add a test for this?

@ayu-666
Copy link
Author

ayu-666 commented Feb 9, 2022

image
when using the history mode, navigate to hash link will cause 404

@jhildenbiddle jhildenbiddle self-requested a review Feb 9, 2022
jhildenbiddle
jhildenbiddle requested changes Feb 9, 2022
View changes
Copy link
Member

@jhildenbiddle jhildenbiddle left a comment •
edited

Please fix ESLint errors and add an integration test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhildenbiddle jhildenbiddle

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayu-666 @jhildenbiddle @trusktr @sy-records