Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GIL code into its own file #96177

Open
markshannon opened this issue Aug 22, 2022 · 2 comments
Open

Move GIL code into its own file #96177

markshannon opened this issue Aug 22, 2022 · 2 comments
Assignees
@markshannon

Comments

@markshannon
Copy link
Member

markshannon commented Aug 22, 2022

Currently the GIL code lives in ceval.c
ceval.c is a large file (8k lines) and doesn't need to contain the GIL code.
It used to, as it was quite tightly coupled with the interpreter, but that is no longer the case.

Apart from general code health, moving the GIL code to its own file will ease generating the interpreter and other performance work.
@markshannon markshannon self-assigned this Aug 22, 2022
@markshannon
Copy link
Member Author

markshannon commented Aug 23, 2022

Hopefully this will also ease maintenance of the GIL code. Having it in one place makes it easier to understand.

@bedevere-bot bedevere-bot mentioned this issue Aug 23, 2022
Merged
markshannon added a commit that referenced this issue Aug 24, 2022
@markshannon
GH-96177: Move GIL and eval breaker code out of ceval.c into ceval_gi…
a4a9f2e 
…l.c. (GH-96204)
mdboom pushed a commit to mdboom/cpython that referenced this issue Aug 24, 2022
@markshannon @mdboom
pythonGH-96177: Move GIL and eval breaker code out of ceval.c into ce…
f5d03d9 
…val_gil.c. (pythonGH-96204)
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Sep 6, 2022

#96204 moved the code to new file, @markshannon anything left to do here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markshannon markshannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markshannon @kumaraditya303