Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45393: help() on operator precedence has misleading entries #31246

Merged
merged 1 commit into from May 19, 2022

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Feb 10, 2022

Fix the formatting for "await x" and "not x" in the operator
precedence table.

https://bugs.python.org/issue45393

zware
zware approved these changes Feb 10, 2022
Copy link
Member

@zware zware left a comment

LGTM, but I would suggest leaving out the change to Lib/pydoc_data/topics.py. It is regenerated for every release, and keeping it will cause backports to fail.

Fix the formatting for "await x" and "not x" in the operator
precedence table.
@ambv ambv force-pushed the bpo-45393-await-precedence-docs branch from 5e5a8f6 to 7e77b9e Compare May 19, 2022
@ambv
Copy link
Contributor

@ambv ambv commented May 19, 2022

I rebased and removed changes to Lib/pydoc_data/topics.py.

zware
zware approved these changes May 19, 2022
@ambv ambv merged commit fb082c2 into python:main May 19, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 19, 2022

Thanks @ZackerySpytz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2022
…onGH-31246)

Fix the formatting for "await x" and "not x" in the operator
precedence table.
(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 19, 2022

GH-92965 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2022
…onGH-31246)

Fix the formatting for "await x" and "not x" in the operator
precedence table.
(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 19, 2022

GH-92966 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2022
…onGH-31246)

Fix the formatting for "await x" and "not x" in the operator
precedence table.
(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 19, 2022

GH-92967 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this issue May 19, 2022
…1246) (GH-92966)

(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ambv pushed a commit that referenced this issue May 19, 2022
…1246) (GH-92967)

(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ambv pushed a commit that referenced this issue May 19, 2022
…1246) (GH-92965)

(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants