gh-96385: Correctly raise error on [*T, *V] substitution
#96386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
gvanrossum
approved these changes
Aug 29, 2022
| @@ -1074,7 +1074,7 @@ def __typing_subst__(self, arg): | |||
| def __typing_prepare_subst__(self, alias, args): | |||
| params = alias.__parameters__ | |||
| typevartuple_index = params.index(self) | |||
| for param in enumerate(params[typevartuple_index + 1:]): | |||
| for param in params[typevartuple_index + 1:]: | |||
There was a problem hiding this comment.
Oh wow this code was just broken. :-)
|
Since this is an outright bug maybe it should be backported? (Possibly not in 3.11.0, it's not important enough to disturb RC2, but definitely in 3.11.1.) Also, pinging @serhiy-storchaka as the original author (AFAICT). |
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2022
…honGH-96386) (cherry picked from commit 7517735) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-96407 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this was the original intent.
The path is now fully covered:
TypeVarTuple.__typing_prepare_subst__does not work as intented #96385