Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial typo in a comment in the source code: "If a callaback raises an exception" #96292

Closed
williamstein opened this issue Aug 25, 2022 · 0 comments
Closed

trivial typo in a comment in the source code: "If a callaback raises an exception" #96292

williamstein opened this issue Aug 25, 2022 · 0 comments
Labels
docs Documentation in the Doc dir

Comments

@williamstein
Copy link

williamstein commented Aug 25, 2022

There is a trivial typo in a comment here:

cpython/Modules/atexitmodule.c

Line 188 in 804f252

If a callaback raises an exception, it is logged with sys.unraisablehook.");

It says "If a callaback raises an exception" but should say "If a callback raises an exception".
@williamstein williamstein added the docs Documentation in the Doc dir label Aug 25, 2022
ansabgillani added a commit to ansabgillani/cpython that referenced this issue Aug 27, 2022
@ansabgillani
pythongh-96292: Fix Trivial Typo in cpython/Modules/atexitmodule.c
1e09bc9
@ansabgillani ansabgillani mentioned this issue Aug 27, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 27, 2022
@ansabgillani @miss-islington
fixes pythongh-96292: Fix Trivial Typo in cpython/Modules/atexitmodul…
4b3851d 
…e.c (pythonGH-96327)

(cherry picked from commit 0ace820)

Co-authored-by: Ansab Gillani <56605828+ansabgillani@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 27, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 27, 2022
@ansabgillani @miss-islington
fixes pythongh-96292: Fix Trivial Typo in cpython/Modules/atexitmodul…
f292281 
…e.c (pythonGH-96327)

(cherry picked from commit 0ace820)

Co-authored-by: Ansab Gillani <56605828+ansabgillani@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 27, 2022
Merged
miss-islington added a commit that referenced this issue Aug 27, 2022
@miss-islington @ansabgillani
fixes gh-96292: Fix Trivial Typo in cpython/Modules/atexitmodule.c (G…
5d82cef 
…H-96327)

(cherry picked from commit 0ace820)

Co-authored-by: Ansab Gillani <56605828+ansabgillani@users.noreply.github.com>
miss-islington added a commit that referenced this issue Aug 27, 2022
@miss-islington @ansabgillani
fixes gh-96292: Fix Trivial Typo in cpython/Modules/atexitmodule.c (G…
6bd95f9 
…H-96327)

(cherry picked from commit 0ace820)

Co-authored-by: Ansab Gillani <56605828+ansabgillani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@williamstein