bpo-39393: Misleading error message on dependent DLL resolution failure #18093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As @eryksun mentioned in the issue tracker, the suggestion to "Try using the full path with constructor syntax" may not solve the problem when failing to resolve a dependency. Should this sentence perhaps be reworded as well? Maybe something like "Ensure that the file and its dependencies are in the DLL search path" would be more accurate. |
|
Thanks @ZackerySpytz for the PR, and @zooba for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jan 28, 2020
…re (pythonGH-18093) (cherry picked from commit 13c1c35) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-18230 is a backport of this pull request to the 3.8 branch. |
|
Rather than force people to figure out the DLL search path, I'd rather leave the most likely fix right in the message. |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this issue
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Improve the error message when attempting to load a DLL with
unresolved dependencies.
https://bugs.python.org/issue39393