bpo-46841: Quicken code in-place #31888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this results in a 3% memory improvement across all benchmarks: Ignore |
gvanrossum
reviewed
Mar 16, 2022
|
1% perf improvement too: |
gvanrossum
reviewed
Mar 17, 2022
|
This is still marked as draft, what is left to do? |
There is still an awkward spot in I’m still trying to understand the code better and figure out a cleaner way of doing this. Any ideas? |
#31968 should help. |
|
I think it is OK to sort out the peculiarities of |
brandtbucher
added
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
markshannon
reviewed
Mar 21, 2022
markshannon
reviewed
Mar 21, 2022
|
Buildbot failures are all pre-existing failures and unrelated to this PR. |
asvetlov
pushed a commit
to YvesDup/cpython
that referenced
this issue
Mar 25, 2022
* Moves the bytecode to the end of the corresponding PyCodeObject, and quickens it in-place. * Removes the almost-always-unused co_varnames, co_freevars, and co_cellvars member caches * _PyOpcode_Deopt is a new mapping from all opcodes to their un-quickened forms. * _PyOpcode_InlineCacheEntries is renamed to _PyOpcode_Caches * _Py_IncrementCountAndMaybeQuicken is renamed to _PyCode_Warmup * _Py_Quicken is renamed to _PyCode_Quicken * _co_quickened is renamed to _co_code_adaptive (and is now a read-only memoryview). * Do not emit unused nonzero opargs anymore in the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This moves the bytecode to the end of the corresponding
PyCodeObject, and quickens it in-place.Related changes:
PyCodeObjectis now more compact. I've removed the almost-always-unusedco_varnames,co_freevars, andco_cellvarsmember caches, and rearranged someintmembers to fill some holes in the struct on 64-bit builds.co_codehas been removed and replaced with_PyCode_GetCode, andco_quickenedandco_firstinstrhave been replaced with_PyCode_CODE._PyOpcode_Deoptis a new mapping from all opcodes to their un-quickened forms._PyOpcode_InlineCacheEntriesis renamed to_PyOpcode_Caches,_Py_IncrementCountAndMaybeQuickenis renamed to_PyCode_Warmup,_Py_Quickenis renamed to_PyCode_Quicken, and_co_quickenedis renamed to_co_code_adaptive(and is now a read-onlymemoryview).https://bugs.python.org/issue46841