Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96641: Do not expose KeyWrapper in _functoolsmodule.c #96642

Merged
merged 1 commit into from Sep 7, 2022
Merged

gh-96641: Do not expose KeyWrapper in _functoolsmodule.c #96642

merged 1 commit into from Sep 7, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 7, 2022 •
edited by bedevere-bot

After:

Python 3.12.0a0 (heads/main-dirty:0d04b8d9e1, Sep  7 2022, 13:35:21) [Clang 11.0.0 (clang-1100.0.33.16)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from _functools import KeyWrapper
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'KeyWrapper' from '_functools' (unknown location)
>>>

@sobolevn sobolevn requested a review from rhettinger as a code owner Sep 7, 2022
corona10
corona10 approved these changes Sep 7, 2022
View changes
Copy link
Member

@corona10 corona10 left a comment

lgtm
This should not be exposed.

@corona10 corona10 merged commit 2fd7246 into python:main Sep 7, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 7, 2022

Thanks @sobolevn for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 7, 2022

GH-96644 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 7, 2022
@sobolevn @miss-islington
pythongh-96641: Do not expose KeyWrapper in _functoolsmodule.c (p…
77834cb 
…ythongh-96642)

(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Sep 7, 2022

GH-96645 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 7, 2022
@sobolevn @miss-islington
pythongh-96641: Do not expose KeyWrapper in _functoolsmodule.c (p…
945b8f7 
…ythongh-96642)

(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
Member Author

sobolevn commented Sep 7, 2022

Thank you!

miss-islington added a commit that referenced this issue Sep 7, 2022
@miss-islington @sobolevn
gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642)
eecbb54 
(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this issue Sep 7, 2022
@miss-islington @sobolevn
gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642)
8228433 
(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@rhettinger rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sobolevn @miss-islington @bedevere-bot @corona10