Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93461: Invalidate sys.path_importer_cache entries with relative paths #93653

Merged
merged 4 commits into from Jun 10, 2022
Merged

gh-93461: Invalidate sys.path_importer_cache entries with relative paths #93653

merged 4 commits into from Jun 10, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 9, 2022

No description provided.

@tiran tiran requested a review from brettcannon Jun 9, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Jun 9, 2022

One test scenario is failing on WASI:

======================================================================
FAIL: test_reload_location_changed (test.test_importlib.test_api.Source_ReloadTests.test_reload_location_changed)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Lib/test/test_importlib/test_api.py", line 272, in test_reload_location_changed
    self.assertEqual(loader.path, path)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '/pyt[15 chars]n/builddir/wasi/build/test_python_66600æ/tmpkuwglbjj/./spam.py' != '/pyt[15 chars]n/builddir/wasi/build/test_python_66600æ/tmpkuwglbjj/spam.py'
- /python-wasm/cpython/builddir/wasi/build/test_python_66600æ/tmpkuwglbjj/./spam.py
?                                                                         --
+ /python-wasm/cpython/builddir/wasi/build/test_python_66600æ/tmpkuwglbjj/spam.py

@ambv ambv merged commit 09243b8 into python:main Jun 10, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 10, 2022

Thanks @tiran for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 10, 2022
@tiran @miss-islington
pythongh-93461: Invalidate sys.path_importer_cache entries with relat…
163891f 
…ive paths (pythonGH-93653)

(cherry picked from commit 09243b8)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 10, 2022

GH-93698 is a backport of this pull request to the 3.11 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tiran @miss-islington @bedevere-bot @brettcannon @ambv