Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96702: Order methods before attrs in sqlite3.Connection docs #96703

Merged
merged 2 commits into from Sep 13, 2022
Merged

gh-96702: Order methods before attrs in sqlite3.Connection docs #96703

merged 2 commits into from Sep 13, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 9, 2022 •
edited by bedevere-bot

@erlend-aasland erlend-aasland requested a review from CAM-Gerlach Sep 9, 2022
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Sep 9, 2022
@erlend-aasland erlend-aasland linked an issue Sep 9, 2022 that may be closed by this pull request
sqlite3 docs: Connection methods and attribute order #96702
Closed
CAM-Gerlach
CAM-Gerlach approved these changes Sep 12, 2022
View changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Sorry for the delay—LGTM, thanks @erlend-aasland . One minor non-blocking comment.

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland merged commit 49cceeb into python:main Sep 13, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs/connection-order branch Sep 13, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 49cceeb5c998a51bb12b7dbde17b53647bb52113 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2022
@erlend-aasland @miss-islington
pythongh-96702: Order methods before attrs in sqlite3.Connection docs (…
018dd06 
…pythonGH-96703)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 13, 2022

GH-96788 is a backport of this pull request to the 3.11 branch.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Sep 13, 2022
@erlend-aasland
[3.10] pythongh-96702: Order methods before attrs in sqlite3.Connecti…
52f0920 
…on docs (pythonGH-96703).

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 13, 2022

GH-96789 is a backport of this pull request to the 3.10 branch.

@erlend-aasland erlend-aasland mentioned this pull request Sep 13, 2022
Closed
erlend-aasland added a commit that referenced this pull request Sep 13, 2022
@erlend-aasland
[3.10] gh-96702: Order methods before attrs in sqlite3.Connection docs (
fbc768f 
GH-96703). (#96789)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Sep 14, 2022
@miss-islington @erlend-aasland
gh-96702: Order methods before attrs in sqlite3.Connection docs (GH-9…
b31b1b1 
…6703) (#96788)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @erlend-aasland @pablogsal
gh-96702: Order methods before attrs in sqlite3.Connection docs (GH-9…
99f5568 
…6703) (#96788)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach

@berkerpeksag berkerpeksag

Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3 docs: Connection methods and attribute order
4 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach