New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Update example in traceback doc #96600
Conversation
I personally don't feel it's too bad, but there's no harm in changing it. I asked my wife for a second opinion and she said we should change it because the current wording isn't funny anyway.
Somewhat relatedly the example also says "exc_type below is ignored on 3.5 and later". 3.4 is long gone so I don't think we need that text any more. We should also make it simply do traceback_print_exception(exc_value)
instead of the old 3-argument version.
Status check is done, and it's a failure |
Thanks @iritkatriel for the PR |
Sorry @iritkatriel, I had trouble checking out the |
Sorry, @iritkatriel, I could not cleanly backport this to |
This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health. Automerge-Triggered-By: GH:iritkatriel (cherry picked from commit c4999f2) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
GH-96603 is a backport of this pull request to the 3.11 branch. |
This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health. Automerge-Triggered-By: GH:iritkatriel (cherry picked from commit c4999f2)
GH-96605 is a backport of this pull request to the 3.10 branch. |
This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health. Automerge-Triggered-By: GH:iritkatriel (cherry picked from commit c4999f2) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health.
Automerge-Triggered-By: GH:iritkatriel