Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update example in traceback doc #96600

Merged
merged 3 commits into from Sep 5, 2022
Merged

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 5, 2022

This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health.

Automerge-Triggered-By: GH:iritkatriel

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

I personally don't feel it's too bad, but there's no harm in changing it. I asked my wife for a second opinion and she said we should change it because the current wording isn't funny anyway.

Somewhat relatedly the example also says "exc_type below is ignored on 3.5 and later". 3.4 is long gone so I don't think we need that text any more. We should also make it simply do traceback_print_exception(exc_value) instead of the old 3-argument version.

@iritkatriel iritkatriel changed the title reword example in traceback doc [doc] Update example in traceback doc Sep 5, 2022
@iritkatriel iritkatriel added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Sep 5, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Sep 5, 2022

Status check is done, and it's a failure .

@miss-islington miss-islington merged commit c4999f2 into python:main Sep 5, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 5, 2022

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 5, 2022

Sorry @iritkatriel, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c4999f261fb0cb28ef713b48ef2e81ca5a3eb1e1 3.11

@miss-islington miss-islington self-assigned this Sep 5, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Sep 5, 2022

Sorry, @iritkatriel, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c4999f261fb0cb28ef713b48ef2e81ca5a3eb1e1 3.10

iritkatriel added a commit to iritkatriel/cpython that referenced this issue Sep 5, 2022
This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health.

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit c4999f2)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 5, 2022

GH-96603 is a backport of this pull request to the 3.11 branch.

iritkatriel added a commit that referenced this issue Sep 5, 2022
This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health.

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit c4999f2)
@bedevere-bot
Copy link

bedevere-bot commented Sep 5, 2022

GH-96605 is a backport of this pull request to the 3.10 branch.

iritkatriel added a commit that referenced this issue Sep 5, 2022
This Monty Python reference is of-its-time. It could seem inappropriate in the context of today's sensibilities around mental health.

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit c4999f2)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants