Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46968: Check for 'sys/auxv.h' in the configure script #31961

Merged
merged 3 commits into from Mar 18, 2022
Merged

bpo-46968: Check for 'sys/auxv.h' in the configure script #31961

merged 3 commits into from Mar 18, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 17, 2022 •
edited by bedevere-bot

@pablogsal pablogsal requested a review from vstinner Mar 17, 2022
@pablogsal pablogsal added 🤖 automerge needs backport to 3.9 needs backport to 3.10 labels Mar 17, 2022
pablogsal
pablogsal reviewed Mar 17, 2022
View changes
Modules/faulthandler.c Outdated Show resolved Hide resolved
@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Mar 18, 2022

Sorry about the issue. I was thinking of adding the test but then assumed existence of linux/auxvec.h implies existence of sys/auxv.h based on inspection of recent kernels.

vstinner
vstinner approved these changes Mar 18, 2022
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

Modules/faulthandler.c Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

@vstinner vstinner commented Mar 18, 2022

Sorry about the issue. I was thinking of adding the test but then assumed existence of linux/auxvec.h implies existence of sys/auxv.h based on inspection of recent kernels.

Same here. But the Linux ecosystem is always more complicated than what I expect :-)

@pablogsal @vstinner
Update Modules/faulthandler.c
1488358 
Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 18, 2022

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 18, 2022

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 18, 2022

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8e3fde7 into python:main Mar 18, 2022
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 18, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 18, 2022

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e3fde728f547f1d32bde8adf62b4c50bb877b9d 3.10

@miss-islington miss-islington self-assigned this Mar 18, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 18, 2022

Sorry @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e3fde728f547f1d32bde8adf62b4c50bb877b9d 3.9

pablogsal added a commit to pablogsal/cpython that referenced this issue Mar 18, 2022
[3.10] bpo-46968: Check for 'sys/auxv.h' in the configure script (pyt…
000dabd 
…honGH-31961).

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Mar 18, 2022
[3.9] bpo-46968: Check for 'sys/auxv.h' in the configure script (pyth…
b66af27 
…onGH-31961).

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 18, 2022

GH-31975 is a backport of this pull request to the 3.9 branch.

pablogsal pushed a commit that referenced this issue Mar 18, 2022
[3.9] bpo-46968: Check for 'sys/auxv.h' in the configure script (GH-3…
a12ef81 
…1961). (GH-31975)

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal pushed a commit that referenced this issue Mar 18, 2022
[3.10] bpo-46968: Check for 'sys/auxv.h' in the configure script (GH-…
6fd9737 
…31961). (GH-31974)

(cherry picked from commit 8e3fde7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
asvetlov added a commit to YvesDup/cpython that referenced this issue Mar 25, 2022
@asvetlov
bpo-46968: Check for 'sys/auxv.h' in the configure script (pythonGH-3…
c43b540 
…1961)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@oleksandr-pavlyk oleksandr-pavlyk

Assignees

@miss-islington miss-islington

Labels
CLA signed needs backport to 3.10 🤖 automerge
Projects
None yet
Milestone
No milestone
6 participants
@pablogsal @oleksandr-pavlyk @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni