[Serializer] Fix inconsistent behaviour of nullable objects in key/value arrays #45884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phramz
commented
Mar 29, 2022
•
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #45883 |
| License | MIT |
| Doc PR | - |
|
Hey! I think @Th3Mouk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
I don't know about the change, but this should target 5.4 or maybe 4.4 if the bug exists there also. Can you please confirm? |
alamirault
reviewed
Apr 2, 2022
src/Symfony/Component/Serializer/Tests/Normalizer/MapDenormalizationTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/MapDenormalizationTest.php
Outdated
Show resolved
Hide resolved
|
@nicolas-grekas yes this also applies to 5.4.x (I changed the PR to target 5.4 now) ... 4.4.x seems to be far off so running the test will result in totally different errors so i guess it's incompatible. Maybe someone with deeper knowledge/understanding of the component can check on 4.4? |
…lue arrays Fixes symfony/45883
nicolas-grekas
changed the title
nicolas-grekas
changed the title
|
/cc @symfony/mergers anyone available to review this one? |
|
@nicolas-grekas No one here to review? We also would love to see this fixed. |
ogizanagi
approved these changes
Jul 19, 2022
|
Thank you @phramz. |
This was referenced Jul 29, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.