Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl.SSLSocket.shared_ciphers always returns server cipher list #96931

Closed
benfogle opened this issue Sep 19, 2022 · 0 comments
Closed

ssl.SSLSocket.shared_ciphers always returns server cipher list #96931

benfogle opened this issue Sep 19, 2022 · 0 comments
Labels
topic-SSL type-bug An unexpected behavior, bug, or error

Comments

@benfogle
Copy link
Contributor

benfogle commented Sep 19, 2022 •
edited by bedevere-bot

Bug report

The function ssl.SSLSocket.shared_ciphers always returns the server's cipher list, rather than the ciphers common to both client and server. I.e., the same list as ssl.SSLContext.get_ciphers, in a different format.

This is due to the use of SSL_get_ciphers in the implementation, rather than SSL_get_shared_ciphers.

Your environment

  • CPython versions tested on: 3.8.10, 3.12.0a0
  • Operating system and architecture: Ubuntu 20.04, x86_64

Linked PRs
@benfogle benfogle added the type-bug An unexpected behavior, bug, or error label Sep 19, 2022
@bedevere-bot bedevere-bot mentioned this issue Sep 19, 2022
Merged
Yhg1s pushed a commit that referenced this issue Mar 22, 2023
@benfogle
gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (#96932)
af9c34f
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 22, 2023
@benfogle @miss-islington
pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…
0c15975 
…pythonGH-96932)

(cherry picked from commit af9c34f)

Co-authored-by: Benjamin Fogle <benfogle@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Mar 22, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 22, 2023
@benfogle @miss-islington
pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…
88d3673 
…pythonGH-96932)

(cherry picked from commit af9c34f)

Co-authored-by: Benjamin Fogle <benfogle@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Mar 22, 2023
Merged
Yhg1s pushed a commit that referenced this issue Mar 24, 2023
@miss-islington @benfogle
[3.11] gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (
e075631 
GH-96932) (#102918)

gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (GH-96932)
(cherry picked from commit af9c34f)

Co-authored-by: Benjamin Fogle <benfogle@gmail.com>
Yhg1s pushed a commit that referenced this issue Mar 24, 2023
@miss-islington @benfogle
[3.10] gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (
0a2b63f 
GH-96932) (#102919)

gh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (GH-96932)
(cherry picked from commit af9c34f)

Co-authored-by: Benjamin Fogle <benfogle@gmail.com>
@Yhg1s Yhg1s closed this as completed Mar 24, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@benfogle @Fidget-Spinner
pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…
233ef6d 
…python#96932)
@Ousret Ousret mentioned this issue Apr 10, 2023
Closed
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@benfogle @warsaw
pythongh-96931: Fix incorrect results in ssl.SSLSocket.shared_ciphers (…
7c770f2 
…python#96932)
@graingert graingert mentioned this issue Apr 12, 2023
Merged
@kevinAlbs kevinAlbs mentioned this issue Jul 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-SSL type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yhg1s @ned-deily @benfogle