gh-90716: add _pylong.py module #96673
Open
+248
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Python implementations of certain longobject.c algorithms. These can be much faster on large numbers. Co-author: Tim Peters <tim.peters@gmail.com> Co-author: Mark Dickinson <dickinsm@gmail.com>
|
Some relevant discussion on the pros and cons of adding these "smarter" but more complicated algorithms: https://discuss.python.org/t/faster-large-integer-multiplication/13300 I think implementing them in Python lowers the bar quite a bit in terms of what is maintainable in the long term. We have a small number of core devs who are numeric experts so we need to be cautious about adding a bunch of complex code. Maybe this PR already goes too far? It feels like pretty good "bang for buck" to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add Python implementations of certain longobject.c functions. These use smarter algorithms and can be much faster on large numbers. Currently implemented is
long_to_decimal_string()(based on code from Tim) anddivmod_fast()(based on code from Mark). The longobject.c module has been changed to call into_pylongif the Python version is likely to be faster.Note: This is a work-in-progress. Needs cleanup, unit tests, etc.
Co-author: Tim Peters tim.peters@gmail.com
Co-author: Mark Dickinson dickinsm@gmail.com