Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upstream openssl 1.1.1q patch for trivial build error on macOS #96594

Merged
merged 1 commit into from Sep 5, 2022
Merged

Add upstream openssl 1.1.1q patch for trivial build error on macOS #96594

merged 1 commit into from Sep 5, 2022

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented Sep 5, 2022

Fix OpenSSL 1.1.1q build error in macOS installer by including a post-1.1.1q fix from upstream:

This fixes a regression in 1.1.1q:

test/v3ext.c:201:24: error: implicitly declaring library function 'memcmp' with type 'int (const void *, const void *, unsigned long)' [-Werror,-Wimplicit-function-declaration]
        if (!TEST_true(memcmp(ip1->data, ip2->data, ip1->length) <= 0))

@ned-deily ned-deily requested a review from a team as a code owner Sep 5, 2022
@ned-deily ned-deily requested a review from pablogsal Sep 5, 2022
@ned-deily ned-deily merged commit 991b371 into python:main Sep 5, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 5, 2022

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 5, 2022
@ned-deily @miss-islington
Add upstream openssl 1.1.1q patch for trivial build error on macOS (p…
a6577ca 
…ythonGH-96594)

(cherry picked from commit 991b371)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Sep 5, 2022

GH-96596 is a backport of this pull request to the 3.11 branch.

@ned-deily ned-deily deleted the openssl11q-patch branch Sep 5, 2022
@bedevere-bot
Copy link

bedevere-bot commented Sep 5, 2022

GH-96597 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 5, 2022
@ned-deily @miss-islington
Add upstream openssl 1.1.1q patch for trivial build error on macOS (p…
fe295a5 
…ythonGH-96594)

(cherry picked from commit 991b371)

Co-authored-by: Ned Deily <nad@python.org>
miss-islington added a commit that referenced this issue Sep 5, 2022
@miss-islington @ned-deily
Add upstream openssl 1.1.1q patch for trivial build error on macOS (G…
75c3a4c 
…H-96594)

(cherry picked from commit 991b371)

Co-authored-by: Ned Deily <nad@python.org>
miss-islington added a commit that referenced this issue Sep 5, 2022
@miss-islington @ned-deily
Add upstream openssl 1.1.1q patch for trivial build error on macOS (G…
c612cc2 
…H-96594)

(cherry picked from commit 991b371)

Co-authored-by: Ned Deily <nad@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@python/macos-team macos-team

Assignees
No one assigned
Labels
3.10 3.11 3.12 build The build process and cross-build skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ned-deily @miss-islington @bedevere-bot @pablogsal