DEV: refactor bootbox alerts #18292
Merged
DEV: refactor bootbox alerts #18292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
force-pushed
the
a11y-refactor-bootbox-alerts
branch
from
f6d7092
to
a49ded2
Compare
|
Any chance that "Acceptance: Discourse Chat - Chat live pane - handling 429 errors: Handles 429 errors by displaying an alert" failure is related to these changes? |
|
Yes, it is related, the chat test is assuming core uses bootbox. Will do the same "disable test in plugin temporarily" dance tomorrow. |
pmusaraj
force-pushed
the
a11y-refactor-bootbox-alerts
branch
from
a49ded2
to
718375f
Compare
ZogStriP
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.