Skip to content

build(bazel): allow tag propagation on host machine #47615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kormide
Copy link
Contributor

@kormide kormide commented Oct 3, 2022

@devversion @josephperrott @gregmagolan

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

tags = ["requires-network"] doesn't get propagated on the host machine, causing one of the git dgeni filters to misbehave.

What is the new behavior?

Tags are propagated locally.

Does this PR introduce a breaking change?

  • Yes
  • No

Fixes a bug where 'requires-network' tag was not propagated locally.
@pullapprove pullapprove bot requested a review from gkalpak October 3, 2022 19:53
@devversion devversion merged commit 29561c9 into angular:aio-bazel-migration Oct 4, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants