Skip to content

docs: fix linter errors for angular-compiler-options.md page (#47179) #47618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: fix linter errors for angular-compiler-options.md page (#47179) #47618

wants to merge 1 commit into from

Conversation

dsnoeijer
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #47179

What is the new behavior?

File no longer has linter errors.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from AndrewKushnir October 3, 2022 21:49
@ngbot ngbot bot added this to the Backlog milestone Oct 3, 2022
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 3, 2022
bob-watson
bob-watson suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bob-watson bob-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits.
You picked a very challenging topic to edit, so double thanks.
The majority of your edits are great. I tagged a few that were unusually complex for you to review.
Thanks for your contribution!

bob-watson
bob-watson approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@bob-watson bob-watson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, again for taking on this topic to edit.
LGTM!

Reviewed-for: global-docs-approvers

@dsnoeijer can you squash these commits so we can merge the result, please?
Thanks!

@bob-watson bob-watson added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 5, 2022
@AndrewKushnir AndrewKushnir removed their request for review October 5, 2022 15:42
@dsnoeijer
docs: fix linter errors for angular-compiler-options.md page (angular…
2d742ce 
…#47179)

fixup! docs: fix linter errors for angular-compiler-options.md page (angular#47179)
@dsnoeijer
Copy link
Contributor Author

@bob-watson Done.

@bob-watson
Copy link
Contributor

@AndrewKushnir this is ready for your review.

@bob-watson bob-watson added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 5, 2022
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 5, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 0035ccf.

jessicajaniuk pushed a commit that referenced this pull request Oct 5, 2022
@dsnoeijer @thePunderWoman
docs: fix linter errors for angular-compiler-options.md page (#47179) (…
229629b 
…#47618)

fixup! docs: fix linter errors for angular-compiler-options.md page (#47179)

PR Close #47618
@dsnoeijer dsnoeijer deleted the docs-update branch October 6, 2022 23:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bob-watson bob-watson bob-watson approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@dsnoeijer @bob-watson @jessicajaniuk @AndrewKushnir