Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenizer returnings pointers make calculation of position info more complicated #97973

Closed
lysnikolaou opened this issue Oct 6, 2022 · 0 comments · Fixed by #97984
Closed

Tokenizer returnings pointers make calculation of position info more complicated #97973

lysnikolaou opened this issue Oct 6, 2022 · 0 comments · Fixed by #97984
Assignees
@lysnikolaou
Labels
type-feature A feature request or enhancement

Comments

@lysnikolaou
Copy link
Contributor

lysnikolaou commented Oct 6, 2022

Bacause the tokenizer only returns pointers to the beginning and the end of the token, calculating line numbers/column offsets is more complicated than needed.

Feature or enhancement

Instead of the tokenizer returning a token type and settings pointers, we wanna return the token type (remains as is) and then set a struct token that has the following information:

  1. Pointers to beginning and end
  2. Location information (lineno, col_offset, etc.)
  3. Level (the level in the parenstack)

This way the parser will have a much easier job of setting line numbers & column offsets in the generated AST numbers and will make some of our work on the f-strings parsing easier.
@lysnikolaou lysnikolaou added the type-feature A feature request or enhancement label Oct 6, 2022
@lysnikolaou lysnikolaou self-assigned this Oct 6, 2022
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue Oct 6, 2022
@lysnikolaou
pythonGH-97973: Return all necessary information from the tokenizer
5f05ce9 
Right now, the tokenizer only returns type and two pointers to the
start and end of the token. This PR modifies the tokenizer to return
the type and set all of the necessary information, so that the parser
does not have to this.
@bedevere-bot bedevere-bot mentioned this issue Oct 6, 2022
Closed
@lysnikolaou lysnikolaou linked a pull request Oct 6, 2022 that will close this issue
GH-97973: Return all necessary information from the tokenizer #97975
Closed
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue Oct 6, 2022
@lysnikolaou
pythongh-97973: Return all necessary information from the tokenizer
0a7d0f6 
Right now, the tokenizer only returns type and two pointers to the start and end of the token.
This PR modifies the tokenizer to return the type and set all of the necessary information,
so that the parser does not have to this.
@bedevere-bot bedevere-bot mentioned this issue Oct 6, 2022
Merged
@lysnikolaou lysnikolaou linked a pull request Oct 6, 2022 that will close this issue
gh-97973: Return all necessary information from the tokenizer #97984
Merged
lysnikolaou added a commit that referenced this issue Oct 6, 2022
@lysnikolaou
gh-97973: Return all necessary information from the tokenizer (GH-97984)
cbf0afd 
Right now, the tokenizer only returns type and two pointers to the start and end of the token.
This PR modifies the tokenizer to return the type and set all of the necessary information,
so that the parser does not have to this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lysnikolaou lysnikolaou

Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
1 participant
@lysnikolaou