Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-97973: Return all necessary information from the tokenizer #97984

Merged
merged 7 commits into from Oct 6, 2022

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Oct 6, 2022

Right now, the tokenizer only returns type and two pointers to the start and end of the token. This PR modifies the tokenizer to return the type and set all of the necessary information, so that the parser does not have to this.

Right now, the tokenizer only returns type and two pointers to the start and end of the token.
This PR modifies the tokenizer to return the type and set all of the necessary information,
so that the parser does not have to this.
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

Great work 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokenizer returnings pointers make calculation of position info more complicated
3 participants