Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 594: Process "to be removed in 3.12" part of the plan #93243

Open
1 of 4 tasks
arhadthedev opened this issue May 26, 2022 · 2 comments
Open
1 of 4 tasks

PEP 594: Process "to be removed in 3.12" part of the plan #93243

arhadthedev opened this issue May 26, 2022 · 2 comments
Labels
type-feature A feature request or enhancement

Comments

@arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented May 26, 2022 •
edited

Reference: PEP 594 – Removing dead batteries from the standard library.

This issue tracks removal of the following modules:

  • asynchat
  • asyncore
  • smtpd
    • remove from the public API
    • totally eliminate

Initially I just wanted to clean ssh tests from smtpd but found myself here.
@arhadthedev arhadthedev added the type-feature A feature request or enhancement label May 26, 2022
@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 26, 2022

This requires finishing #1864 (which I need to get back to).

arhadthedev added a commit to arhadthedev/cpython that referenced this issue May 26, 2022
@arhadthedev
pythongh-93243: Make smtpd private to port its users
021e85c
@arhadthedev arhadthedev mentioned this issue May 26, 2022
Merged
@AA-Turner AA-Turner mentioned this issue Jun 7, 2022
Open
@arhadthedev
Copy link
Contributor Author

@arhadthedev arhadthedev commented Jul 12, 2022

Asyncore-based test servers from test_ftp and test_logging cannot be ported to asyncio, the tested clients are blocking. However, instead of writing a server thread class from scratch, it would be nice to reuse test.support.threading_helper.Server from gh-92475.

miss-islington pushed a commit that referenced this issue Aug 6, 2022
@arhadthedev
gh-93243: Make smtpd private before porting its users (GH-93246)
56d16e8 
gh-93243

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @arhadthedev