Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyFrame_New creates frame objects backed by incomplete frames #97779

Closed
brandtbucher opened this issue Oct 3, 2022 · 0 comments
Closed

PyFrame_New creates frame objects backed by incomplete frames #97779

brandtbucher opened this issue Oct 3, 2022 · 0 comments
Assignees
@brandtbucher
Labels
3.11 only security fixes 3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) sprint type-bug An unexpected behavior, bug, or error

Comments

@brandtbucher
Copy link
Member

It's called by _PyTraceback_Add a few places in the stdlib. We should set f_lasti == 0 when creating these.

CC @markshannon
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error sprint interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.11 only security fixes 3.12 bugs and security fixes labels Oct 3, 2022
@brandtbucher brandtbucher self-assigned this Oct 3, 2022
@bedevere-bot bedevere-bot mentioned this issue Oct 4, 2022
Merged
brandtbucher added a commit that referenced this issue Oct 5, 2022
@brandtbucher
GH-97779: Ensure that *all* frame objects are backed by "complete" fr…
0ff8fd6 
…ames (GH-97845)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 5, 2022
@brandtbucher @miss-islington
pythonGH-97779: Ensure that *all* frame objects are backed by "comple…
cc9b0dc 
…te" frames (pythonGH-97845)

(cherry picked from commit 0ff8fd6)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot bedevere-bot mentioned this issue Oct 5, 2022
Merged
brandtbucher added a commit that referenced this issue Oct 5, 2022
@miss-islington @brandtbucher
[3.11] GH-97779: Ensure that *all* frame objects are backed by "compl…
015b49a 
…ete" frames (GH-97886)

(cherry picked from commit 0ff8fd6)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022
@brandtbucher @mpage
pythonGH-97779: Ensure that *all* frame objects are backed by "comple…
76e702c 
…te" frames (pythonGH-97845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandtbucher brandtbucher

Labels
3.11 only security fixes 3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) sprint type-bug An unexpected behavior, bug, or error
Projects
Sprint 2022 🏃🏃‍♀
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandtbucher