Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammar changes to http.client docs #96221

Merged
merged 2 commits into from Oct 3, 2022
Merged

Conversation

rshah713
Copy link
Contributor

@rshah713 rshah713 commented Aug 24, 2022

Some small grammatical changes that stood out when reading the http.client documentation.

This is also my first PR to cpython so if there's anything else I need please let me know! Grateful to be able to contribute to such an impactful project :)

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 24, 2022
@rshah713
Copy link
Contributor Author

rshah713 commented Sep 18, 2022

Hey @erlend-aasland, just wanted to bring this trivial PR to your attention before it was buried. Not sure if you're the one to tag but I noticed you merged a similar PR. Let me know if there's anything to change or if it's good to merge :)

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Oct 3, 2022

Thanks for the PR, @rshah713, and thanks for picking this up, Ezio!

@rshah713
Copy link
Contributor Author

rshah713 commented Oct 3, 2022

No problem! Honored to be able to contribute to such a project I've used so much 👍

@orsenthil orsenthil merged commit d053c47 into python:main Oct 3, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 3, 2022

Thanks @rshah713 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 3, 2022

GH-97810 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2022
Minor grammar changes
(cherry picked from commit d053c47)

Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 3, 2022

GH-97811 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2022
Minor grammar changes
(cherry picked from commit d053c47)

Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 3, 2022
Minor grammar changes
(cherry picked from commit d053c47)

Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 3, 2022
Minor grammar changes
(cherry picked from commit d053c47)

Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
Minor grammar changes
(cherry picked from commit d053c47)

Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants