gh-82836: fix private network check #97733
Merged
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".
JelleZijlstra
reviewed
Oct 4, 2022
Misc/NEWS.d/next/Library/2022-10-02-12-38-22.gh-issue-82836.OvYLmC.rst
Outdated
Show resolved
Hide resolved
…YLmC.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
…into fix-issue-82836
|
@JelleZijlstra / @ammaraskar - are you able to take a look at this with the fixes in mind? |
JelleZijlstra
reviewed
Nov 16, 2022
gpshead
approved these changes
Nov 29, 2022
gpshead
added
type-bug
|
GH-99887 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2022
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0". (cherry picked from commit ed39109) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Nov 29, 2022
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0". (cherry picked from commit ed39109) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".