Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-97779: Ensure that *all* frame objects are backed by "complete" frames #97845

Merged
merged 10 commits into from Oct 5, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Oct 4, 2022

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error sprint interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 labels Oct 4, 2022
@brandtbucher brandtbucher requested a review from markshannon as a code owner Oct 4, 2022
@brandtbucher brandtbucher self-assigned this Oct 4, 2022
Copy link
Member

@markshannon markshannon left a comment

One minor issue, otherwise looks good.

Lib/test/test_code.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Oct 4, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@brandtbucher brandtbucher merged commit 0ff8fd6 into python:main Oct 5, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 5, 2022

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 5, 2022

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 5, 2022

GH-97886 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
…te" frames (pythonGH-97845)

(cherry picked from commit 0ff8fd6)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) sprint type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants