Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on capture_output arg to subprocess.run() docstring #98012

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Oct 7, 2022

It may be worth to have a separate paragraph for this argument, I'm not sure.

Copy link
Member

@nanjekyejoannah nanjekyejoannah left a comment

LGTM

@nanjekyejoannah nanjekyejoannah merged commit 80b3e32 into python:main Oct 7, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 7, 2022

Thanks @akulakov for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
…H-98012)

add note on capture_output arg to the docstring
(cherry picked from commit 80b3e32)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 7, 2022

GH-98034 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 7, 2022

GH-98035 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
…H-98012)

add note on capture_output arg to the docstring
(cherry picked from commit 80b3e32)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
gpshead
gpshead approved these changes Oct 7, 2022
miss-islington added a commit that referenced this pull request Oct 7, 2022
add note on capture_output arg to the docstring
(cherry picked from commit 80b3e32)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
miss-islington added a commit that referenced this pull request Oct 7, 2022
add note on capture_output arg to the docstring
(cherry picked from commit 80b3e32)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@akulakov
Copy link
Contributor Author

akulakov commented Oct 9, 2022

Thanks!

@akulakov akulakov deleted the Add-capture_output-note-to-run-docstring branch Oct 9, 2022
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants