[3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD #98037

ambv · 2022-10-07T17:30:47Z

Example buildbot failure we want to avoid:
https://buildbot.python.org/all/#/builders/151/builds/595/steps/5/logs/stdio

Relevant log excerpt:

0:38:34 load avg: 1.32 Re-running test_ssl in verbose mode (matching: test__create_stdlib_context, test_protocol, test_session_stats)
test__create_stdlib_context (test.test_ssl.ContextTests) ... ERROR
test_protocol (test.test_ssl.ContextTests) ... ERROR
test_session_stats (test.test_ssl.ContextTests) ... ERROR
======================================================================
ERROR: test__create_stdlib_context (test.test_ssl.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_ssl.py", line 1718, in test__create_stdlib_context
    ctx = ssl._create_stdlib_context(ssl.PROTOCOL_TLSv1,
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 776, in _create_unverified_context
    context = SSLContext(protocol)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 484, in __new__
    self = _SSLContext.__new__(cls, protocol)
ValueError: invalid or unsupported protocol version
======================================================================
ERROR: test_protocol (test.test_ssl.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_ssl.py", line 1144, in test_protocol
    ctx = ssl.SSLContext(proto)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 484, in __new__
    self = _SSLContext.__new__(cls, protocol)
ValueError: invalid or unsupported protocol version
======================================================================
ERROR: test_session_stats (test.test_ssl.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_ssl.py", line 1527, in test_session_stats
    ctx = ssl.SSLContext(proto)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/ssl.py", line 484, in __new__
    self = _SSLContext.__new__(cls, protocol)
ValueError: invalid or unsupported protocol version
----------------------------------------------------------------------
Ran 3 tests in 0.043s
FAILED (errors=3)
test test_ssl failed

Issue: test_ssl fails on recent FreeBSD (OpenSSL 1.1.1p), minimum_version=TLSv1_2 #94208

pythongh-94208: Add even more TLS version/protocol checks for FreeBSD

eeb9507

ambv requested a review from tiran as a code owner Oct 7, 2022

bedevere-bot added the awaiting core review label Oct 7, 2022

ambv changed the title ~~gh-94208: Add even more TLS version/protocol checks for FreeBSD~~ [3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD Oct 7, 2022

ambv added the skip news label Oct 7, 2022

ambv merged commit da1fe38 into python:3.9 Oct 7, 2022
15 checks passed

bedevere-bot removed the awaiting core review label Oct 7, 2022

ambv deleted the fix-unsupported-ssl-proto branch Oct 7, 2022

[3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD #98037

[3.9] gh-94208: Add even more TLS version/protocol checks for FreeBSD #98037

Conversation

ambv commented Oct 7, 2022 • edited by bedevere-bot

ambv commented Oct 7, 2022 •

edited by bedevere-bot