Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip-news and type-tests badges #421

Open
sobolevn opened this issue Jan 8, 2022 · 4 comments
Open

skip-news and type-tests badges #421

sobolevn opened this issue Jan 8, 2022 · 4 comments
Labels
labels

Comments

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 8, 2022 •
edited

The short story

It would be nice if skip-news label is automatically added when both conditions are true:

  • PR has type-tests badge
  • It does not have new NEWS entry

Example: python/cpython#30472

Long version

I love working on unit-tests in CPython, but I have a small problem. When I submit a PR the CI is usually red, because NEWS check fails: there's no NEWS entry.

Most of the reviewers say that test-only changes should not go to NEWS (and I agree). But, right now the only way for non-members is to wait for someone who will put skip-news badge manually to turn the CI to be green. I don't think that precious time should be spent on that! 🙂

Otherwise, it is less-likely to get a review (because PR has this red cross as its status, some people might think that something is broken).
For new contributors this might be even more problematic.
@corona10
Copy link
Member

@corona10 corona10 commented Jan 8, 2022 •
edited

@sobolevn off-topic,
Are you interested in becoming a Triage member?
If so, please mail me :) (see my Github profile)
I have the bandwidth to mentor you as a triage member :)

@kumaraditya303
Copy link

@kumaraditya303 kumaraditya303 commented Jan 9, 2022

In my experience, skip-news label should also be added to type-documentation PRs as generally docs PRs don't require a news fragment.

@isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Jan 9, 2022

Please see #363 for the previous discussion in this matter.

@ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Jun 5, 2022

IMHO the opt-out model we currently have works well enough and makes the check more predictable. We could add custom rules for docs or tests, but they would have to be documented and there are cases where a NEWS entry is still required.

@ezio-melotti ezio-melotti added the labels label Jun 5, 2022
@ezio-melotti ezio-melotti mentioned this issue Jun 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
labels
Projects
CPython labels
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sobolevn @corona10 @ezio-melotti @isidentical @kumaraditya303