bpo-46544: do not leak x and uspace in textwrap
#30955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
changed the title
x and uspace in textwrapx and uspace in textwrap
sobolevn
changed the title
x and uspace in textwrapx and uspace in textwrap
Lib/textwrap.py
Outdated
| @@ -67,6 +67,7 @@ class TextWrapper: | |||
| uspace = ord(' ') | |||
| for x in _whitespace: | |||
| unicode_whitespace_trans[ord(x)] = uspace | |||
| del x, uspace | |||
There was a problem hiding this comment.
I suggest to replace it with
unicode_whitespace_trans = {ord(x): b' '[0] for x in _whitespace}or
unicode_whitespace_trans = dict.fromkeys(map(ord, _whitespace), ord(' '))
This was referenced Jan 27, 2022
serhiy-storchaka
approved these changes
Jan 27, 2022
merwok
reviewed
Jan 28, 2022
| @@ -0,0 +1,2 @@ | |||
| Don't leak ``x`` & ``uspace`` intermediate vars in | |||
| :class:`textwrap.TextWrapper`. | |||
There was a problem hiding this comment.
A news entry for such internal changes seems to have low value for end users!
There was a problem hiding this comment.
It's useful in the unlikely case someone is relying on these attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46544