✨ Added new algorithm for dateToDay conversion #3430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siriak your feedback on this will really help me out. |
debasishbsws
requested changes
Oct 29, 2022
Comment on lines
+17
to
+26
| public static void main(String[] args) { | ||
| Scanner sc = new Scanner(System.in); // Create a Scanner object | ||
| System.out.println("Enter date in dd/mm/yyyy format"); | ||
|
|
||
| String date = sc.nextLine(); // Read user input | ||
| String weekDay = findDayFromDate(date); | ||
|
|
||
| System.out.println("WeekDay is: " + weekDay); // Output WeekDay for given date | ||
| sc.close(); | ||
| } |
Comment on lines
+33
to
+34
| * @param date String format date | ||
| * @return Name of day |
There was a problem hiding this comment.
Suggested change
| * @param date String format date | |
| * @return Name of day | |
| * @param date String format date `DD/MM/YYYY` | |
| * @return Name of the day |
| * 1. For date 2/3/2014 with old formula - (2 * century) weekDay comes as -6 and wrong day | ||
| * 2. With computer logic + (5 * century) it gives proper valid day as Sunday | ||
| */ | ||
| double weekDay = (day + Math.floor((month + 1) * 2.6) + yearDigit + Math.floor(yearDigit / 4) + Math.floor(century / 4) + (5 * century)) % 7; |
There was a problem hiding this comment.
Try to make it more Readable. One liner is good but Readability is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added a new algorithm for finding the name of the day from date (dd/mm/yyyy) using Zeller's Congruence
References
Checklist:
Fixes: #{$ISSUE_NO}.